Fix CarryOverFreshness mangling other transition types - #91
Open
TealSeer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes anegostudios/VintageStory-Issues#3476 and fixes anegostudios/VintageStory-Issues#9374
The issue here was that
CarryOverFreshnessonly operated on thePerishtype ofTransitionProperties, which made sense, but when it wrote to the itemstack attributes it would replace items that had multiple transition states with atransitionstatethat just had the perish numbers, which then causesUpdateAndGetTransitionStatesNativeto compensate by copying whatever numbers are there to fill the other states. This leads to e.g. raw waxed cheese'sRipentransition having all the numbers for itsPerishtransition i.e. non-zerofreshHours. This in turn causes weirdness where the cheese counts down ~20 days (of fresh hours), then starts "ripening" and counts down another ~20 days (of the actual transition hours), entering the negatives in the process.I would have liked to fix this without changing public method signatures, but it wasn't really possible. I just changed the method to take the entire
TransitionProperties[]array and build out the newTreeAttributesas normal, with the existing handling behind a check for thePerishtype